*sigh* error :(

[Coasterdude]

.\g_weapon.c(482) : error C2106: '=' : left operand must be l-value

 

I get that error and I've been trying to fix it for an hour. LoL.

[razorace]

What's on line 482 of that line?

[Coasterdude]

Hmm.. I did some changes and I don't get that error anymore.

Anyway I'm trying to make blaster spread different for movement with this....

Under

static void WP_FireBlaster( gentity_t *ent, qboolean altFire )

in g_weapon.c

 

	if ( altFire )
{
if ( (ent->client->pers.cmd.forwardmove > 0) 
	|| (ent->client->pers.cmd.forwardmove < 0) 
	|| (ent->client->pers.cmd.rightmove < 0) 
	|| (ent->client->pers.cmd.rightmove > 0) )
	{
		angs[PITCH] += crandom() * (wmw_BlasterSpread.integer * 2.0);
		angs[YAW] += crandom() * (wmw_BlasterSpread.integer * 2.0);
	}
else if ( ent->client->pers.cmd.upmove == 0 )
	{
		angs[PITCH] += crandom() * (wmw_BlasterSpread.integer * 4.0);
		angs[YAW] += crandom() * (wmw_BlasterSpread.integer * 4.0);
	}
else
	{
		angs[PITCH] += crandom() * (wmw_BlasterSpread.integer * 1.0);
		angs[YAW] += crandom() * (wmw_BlasterSpread.integer * 1.0);
	}
}

 

also I changed BLASTER_SPREAD to define this

#define BLASTER_SPREAD   wmw_BlasterSpread.integer

wmw_BlasterSpread.integer is 1.6

 

Ingame I do see changes in the spread, but It's not what I wanted. Standing still has alot of spread. crouching gives good accuracy, more accurate than normal spread (1.6). Running has more accurate spread than just standing still lol. So I did something wrong, but I'm not sure what I did wrong.

[razorace]

1. pers.cmd is just the commanded movement direction for the player, not their actual movement.

2. "else if ( ent->client->pers.cmd.upmove == 0 )" will apply if you're not trying to move in any direction other than up/down. This is why you're having crap accuracy when standing still. This should be else if ( ent->client->pers.cmd.upmove > 0 )

 

IE,

if ( ent->client->pers.cmd.upmove > 0 )
{//jumping is the worse, it should go first so it will override normal movement.
}
else if ( (ent->client->pers.cmd.forwardmove > 0) 
	|| (ent->client->pers.cmd.forwardmove < 0) 
	|| (ent->client->pers.cmd.rightmove < 0) 
	|| (ent->client->pers.cmd.rightmove > 0) )
{//for normal movement
}
else if ( ent->client->pers.cmd.upmove < 0 )
{//crouching
}
else
{//standing, not moving.
}

[Coasterdude]

Ahhh.. Thanks. Oh and I'm using the OJP Basic Source Code. and I didn't edit power duel in anyway. When I was playing power duel, I was the single duelist, and I was playing against 2 bots who were on the paired duelists, the second paired duelist always got booted by server command overflow when a new round started.

[razorace]

hmmm, interesting. That's probably due to a infinite team switching loop or something. If you got the qconsole.log of it happening, go ahead and post a bug ticket for it on the OJP bug tracker.

[ensiform]

  Coasterdude said:

Hmm.. I did some changes and I don't get that error anymore.

Anyway I'm trying to make blaster spread different for movement with this....

Under

static void WP_FireBlaster( gentity_t *ent, qboolean altFire )

in g_weapon.c

 

	if ( altFire )
{
if ( (ent->client->pers.cmd.forwardmove > 0) 
	|| (ent->client->pers.cmd.forwardmove < 0) 
	|| (ent->client->pers.cmd.rightmove < 0) 
	|| (ent->client->pers.cmd.rightmove > 0) )
	{
		angs[PITCH] += crandom() * (wmw_BlasterSpread.integer * 2.0);
		angs[YAW] += crandom() * (wmw_BlasterSpread.integer * 2.0);
	}
else if ( ent->client->pers.cmd.upmove == 0 )
	{
		angs[PITCH] += crandom() * (wmw_BlasterSpread.integer * 4.0);
		angs[YAW] += crandom() * (wmw_BlasterSpread.integer * 4.0);
	}
else
	{
		angs[PITCH] += crandom() * (wmw_BlasterSpread.integer * 1.0);
		angs[YAW] += crandom() * (wmw_BlasterSpread.integer * 1.0);
	}
}

 

also I changed BLASTER_SPREAD to define this

#define BLASTER_SPREAD   wmw_BlasterSpread.integer

wmw_BlasterSpread.integer is 1.6

 

Ingame I do see changes in the spread, but It's not what I wanted. Standing still has alot of spread. crouching gives good accuracy, more accurate than normal spread (1.6). Running has more accurate spread than just standing still lol. So I did something wrong, but I'm not sure what I did wrong.

 

well for one that will actually only be 1 due to floor round conversion that is automatically used when you try to do an float when its actually an int. you are going to want cvar.value instead.

[Coasterdude]

Is there something for falling?

[razorace]

Falling or mid-air?

[Coasterdude]

mid-air not pressing anything.

 

EDIT: OOOoo I have an idea! Ima try it out! Ill let you know if it works.

[Coasterdude]

Hmm everything seems to be working correctly except, when you jump you can just let go of all your keys and your accuracy is better lol.

[razorace]

Well, see, that's part of the problem with your design. You're using the player's desired command rather than their actual movement.

[Coasterdude]

im using pm->cmd but same result. So what tracks their actual movement?

[Coasterdude]

Yesss!!! I got it all working perfectly! Thanks for the help guys.